[sgl-kernel] Streamline kernel size report (Top 20 only) and clean up#15552
[sgl-kernel] Streamline kernel size report (Top 20 only) and clean up#15552
Conversation
Summary of ChangesHello @BBuf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the 'sgl-kernel's CUDA kernel size analysis script by significantly streamlining its output and reducing verbosity. The primary goal is to provide a more focused and actionable report, highlighting only the most significant kernel groups and individual kernels (Top 20 each) and aggregating the rest into an 'Other' category. This change aims to make it easier for developers to identify and address performance bottlenecks or code bloat related to kernel sizes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully streamlines the kernel size analysis script. The changes significantly clean up the output by removing verbose logging, timing information, and the JSON export, while focusing the text report on the Top 20 items for both kernel groups and individual kernels. This makes the report much more concise and useful. The accompanying README update is also clear and accurate. I have a couple of minor suggestions to further improve code readability by using f-strings consistently.
Motivation
Follow #14544
Cleans up
sgl-kernel/analyze_whl_kernel_sizes.pyby removing noisy non-essential prints/comments and keeping the output focused on the text report, which summarizes only the Top 20 kernel name-prefix groups and Top 20 individual kernels (with an aggregated “Other” row for the rest).In h200:
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist