[AMD] CI - Detect the aiter version and rebuild if needed#15460
Merged
HaiShaw merged 9 commits intosgl-project:mainfrom Dec 23, 2025
Merged
[AMD] CI - Detect the aiter version and rebuild if needed#15460HaiShaw merged 9 commits intosgl-project:mainfrom
HaiShaw merged 9 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
HaiShaw
approved these changes
Dec 23, 2025
jiaming1130
pushed a commit
to zhuyijie88/sglang
that referenced
this pull request
Dec 25, 2025
YChange01
pushed a commit
to YChange01/sglang
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/sgl-project/sglang/actions/runs/20021784695/job/57446087825
Our AMD CI workflow always pulls the latest pre-built daily Docker image and then installs dependencies based on the PR code. However, this installation step does not rebuild or update AITER, which is already baked into the pre-built image.
As a result, when a PR upgrades the AITER version, the CI does not actually test against the new AITER, but instead tests against whatever version was pre-built into the daily image. This leads to a blind spot where AITER-related regressions cannot be caught at PR time.
Example:
In the PR #14497 , we upgraded AITER to v0.1.7.post5.
In our later manual tests we found that this version introduces an accuracy regression in:
accuracy-test-2-gpu-amd (linux-mi325-gpu-2)
However, the CI for this PR incorrectly passed(see in https://github.com/sgl-project/sglang/actions/runs/20021784695/job/57446087825), because it was still using the older AITER version bundled in the daily image, not the upgraded version specified in the PR.
Conclusion:
We need CI to verify whether the AITER version in the PR matches the one inside the pulled image. If they differ, CI must rebuild/install the correct AITER version inside the container before running tests.
cc: @bingxche @michael-amd @saienduri
Modifications
Accuracy Tests
Simulation - aiter version upgraded to v0.1.8
https://github.com/sgl-project/sglang/actions/runs/20368597241/job/58529505129


Simulation - If aiter version unchanged
https://github.com/sgl-project/sglang/actions/runs/20388611486/job/58594282444?pr=15460

Benchmarking and Profiling
Checklist