[PP] Add dynamic chunking PP test

[ShangmingCai]

Motivation

Add test for dynamic chunking PP with PD disaggregation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.
• Work with maintainers to merge your PR. See the PR Merge Process

[ShangmingCai]

/tag-and-rerun-ci 1

[gemini-code-assist]

Summary of Changes

Hello @ShangmingCai, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a crucial new test case to verify the correct behavior and accuracy of dynamic chunking when combined with pipeline parallelism in a prefill-decode disaggregated inference environment. This enhancement ensures the stability and performance of the system under complex distributed configurations, specifically targeting the gsm8k benchmark.

Highlights

• New Dynamic Chunking Test: Introduced TestDisaggregationPrefillPPDynamicChunkAccuracy to validate dynamic chunking with pipeline parallelism (PP) in a prefill-decode disaggregation setup.
• Test Configuration: The new test configures prefill servers with --enable-dynamic-chunking, --tp-size 2, and --pp-size 2, and decode servers with --tp-size 2 and --base-gpu-id 4.
• Test Suite Update: Updated test/srt/run_suite.py to include the new test and adjusted the allocated time for test_disaggregation_pp.py in the per-commit-8-gpu-h20 suite from 140 to 180 seconds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new test for dynamic chunking in pipeline parallelism with PD disaggregation. The changes are functionally correct. However, I've identified significant code duplication in the new test class and provided a suggestion to refactor it for better maintainability by using inheritance.

[ShangmingCai]

This test should cover #15379 and #15372.

[ShangmingCai]

https://github.com/sgl-project/sglang/actions/runs/20332588139/job/58451878958?pr=15395

All CIs have passed, include the newly added dynamic chunking pp test.