Skip to content

[bug fix][pp] fix inconsistent latency between tp #15379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShangmingCai merged 2 commits into from
Dec 18, 2025
Merged

[bug fix][pp] fix inconsistent latency between tp #15379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42474d8
[bug fix][pp] fix inconsistent latency between tp
XucSh Dec 18, 2025
f693536
use attn tp instead
ShangmingCai Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/sglang/srt/managers/scheduler_pp_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,16 @@ def profile_and_init_predictor(self: Scheduler):
f"seq_lens={seq_lens}, latencies_ms={latencies}"
)

if self.attn_tp_size > 1:
data_to_sync_tp = [seq_lens, latencies]
data_to_sync_tp = broadcast_pyobj(
data_to_sync_tp,
self.attn_tp_group.rank,
self.attn_tp_cpu_group,
src=self.attn_tp_group.ranks[0],
)
seq_lens, latencies = data_to_sync_tp

# Broadcast data to all ranks
if torch.distributed.is_available() and torch.distributed.is_initialized():
data_to_sync = [seq_lens, latencies]
Expand Down Expand Up @@ -866,7 +876,7 @@ def _pp_recv_pyobj_from_prev_stage(self: Scheduler):
else:
data = None

if self.attn_tp_size != 1:
if self.attn_tp_size > 1:
data = broadcast_pyobj(
data,
self.attn_tp_group.rank,
Expand Down
Loading