fix: address review feedback for cache validation CI gating#15210
Closed
alisonshao wants to merge 2 commits intosgl-project:mainfrom
Closed
fix: address review feedback for cache validation CI gating#15210alisonshao wants to merge 2 commits intosgl-project:mainfrom
alisonshao wants to merge 2 commits intosgl-project:mainfrom
Conversation
- Skip entire _find_local_hf_snapshot_dir_unlocked function when not in CI - Remove log line "Found local HF snapshot for..." to reduce noise Addresses review feedback from @merrymercy on sgl-project#14849
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Removed cache validation notes for non-CI environments.
Collaborator
Author
|
address at #15216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback from @merrymercy on #14849.
Changes
Skip entire function when not in CI. Added early return at the beginning of
_find_local_hf_snapshot_dir_unlockedso the function exits immediately when not in CI environment. This avoids the lock file issue that users were seeing during downloads.Removed the "Found local HF snapshot for..." log message.