Skip to content

[diffusion] profile: early exit when enough steps are captured to red… #14803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickqian merged 4 commits into from
Dec 10, 2025
Merged

[diffusion] profile: early exit when enough steps are captured to red… #14803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2f16cd
[diffusion] profile: early exit when enough steps are captured to red…
mickqian Dec 10, 2025
f6411a7
upd
mickqian Dec 10, 2025
9501960
upd
mickqian Dec 10, 2025
d7eaf4e
upd
mickqian Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions python/sglang/multimodal_gen/runtime/pipelines_core/stages/input_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,17 @@ def forward(
batch, server_args, condition_image_width, condition_image_height
)

# if height or width is not specified at this point, set default to 720p
default_height = 720
default_width = 1080
if batch.height is None and batch.width is None:
batch.height = default_height
batch.width = default_width
elif batch.height is None:
batch.height = batch.width * default_height // default_width
elif batch.width is None:
batch.width = batch.height * default_width // default_height

return batch

def verify_input(self, batch: Req, server_args: ServerArgs) -> VerificationResult:
Expand Down Expand Up @@ -251,6 +262,7 @@ def verify_output(self, batch: Req, server_args: ServerArgs) -> VerificationResu
result.add_check("height", batch.height, V.positive_int)
result.add_check("width", batch.width, V.positive_int)
# Validate height and width

if batch.height % 8 != 0 or batch.width % 8 != 0:
raise ValueError(
f"Height and width must be divisible by 8 but are {batch.height} and {batch.width}."
Expand Down
11 changes: 8 additions & 3 deletions python/sglang/multimodal_gen/runtime/utils/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ def __init__(
# profile denoising stage only
warmup = 1
num_actual_steps = num_inference_steps if num_steps == -1 else num_steps
num_active_steps = num_actual_steps + warmup
self.num_active_steps = num_actual_steps + warmup
self.profiler = torch.profiler.profile(
**common_torch_profiler_args,
schedule=torch.profiler.schedule(
skip_first=0,
wait=0,
warmup=warmup,
active=num_active_steps,
active=self.num_active_steps,
repeat=1,
),
)
Expand All @@ -89,7 +89,12 @@ def step_stage(self):

def step_denoising_step(self):
if not self.full_profile:
self._step()
if self.num_active_steps >= 0:
self._step()
self.num_active_steps -= 1
else:
# early exit when enough steps are captured, to reduce the trace file size
self.stop(dump_rank=0)

@classmethod
def get_instance(cls) -> "SGLDiffusionProfiler":
Expand Down
Loading