Skip to content

handling incomplete rope_scaling confign ci after transformers upgrade #14784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 3 commits into from
Dec 10, 2025
Merged

handling incomplete rope_scaling confign ci after transformers upgrade #14784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
105cd88
upd
yhyang201 Dec 10, 2025
8b6c301
upd
yhyang201 Dec 10, 2025
e0c10dc
upd
yhyang201 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/sglang/srt/models/deepseek_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2704,6 +2704,12 @@ def __init__(
self.config = config
rope_theta = getattr(config, "rope_theta", 10000)
rope_scaling = getattr(config, "rope_scaling", None)
if rope_scaling is not None:
# In transformers 5.0.0rc0+, rope_theta and rope_type are also included in rope_scaling.
# Therefore, if rope_scaling contains only these two keys,
# it effectively means there are no special rope_scaling parameters.
if set(rope_scaling.keys()) <= {"rope_theta", "rope_type"}:
Copy link
Collaborator

@zhyncs zhyncs Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it compatible with old transformers?

rope_scaling = None
max_position_embeddings = getattr(config, "max_position_embeddings", 8192)
self.speculative_algorithm = SpeculativeAlgorithm.from_string(
get_global_server_args().speculative_algorithm
Expand Down
Loading