Skip to content

chore: bump sgl-kernel version to 0.3.19 #14649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ispobock merged 1 commit into from
Dec 8, 2025
Merged

chore: bump sgl-kernel version to 0.3.19 #14649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARG GRACE_BLACKWELL_DEEPEP_BRANCH=gb200_blog_part_2
ARG HOPPER_SBO_DEEPEP_COMMIT=9f2fc4b3182a51044ae7ecb6610f7c9c3258c4d6
ARG DEEPEP_COMMIT=9af0e0d0e74f3577af1979c9b9e1ac2cad0104ee
ARG BUILD_AND_DOWNLOAD_PARALLEL=8
ARG SGL_KERNEL_VERSION=0.3.18.post3
ARG SGL_KERNEL_VERSION=0.3.19
ARG SGL_VERSION=0.5.6
ARG USE_LATEST_SGLANG=0
ARG GDRCOPY_VERSION=2.5.1
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ dependencies = [
"scipy",
"sentencepiece",
"setproctitle",
"sgl-kernel==0.3.18.post3",
"sgl-kernel==0.3.19",
"soundfile==0.13.1",
"tiktoken",
"timm==1.0.16",
Expand Down
2 changes: 1 addition & 1 deletion python/sglang/srt/entrypoints/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ def _set_envs_and_config(server_args: ServerArgs):
if _is_cuda and not get_bool_env_var("SGLANG_SKIP_SGL_KERNEL_VERSION_CHECK"):
assert_pkg_version(
"sgl-kernel",
"0.3.18.post3",
"0.3.19",
"Please reinstall the latest version with `pip install sgl-kernel --force-reinstall`",
)
Comment on lines 738 to 742

@gemini-code-assist gemini-code-assist Bot Dec 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pyproject.toml file pins sgl-kernel to an exact version (==0.3.19), but assert_pkg_version only verifies if the installed version is greater than or equal to the specified one. This inconsistency can lead to bugs if a newer, incompatible version of sgl-kernel is used.

To ensure consistency, this check should be for exact equality.

A direct change here might break the automation script that generated this PR. I recommend a follow-up to update assert_pkg_version to support equality checks and then update this call and the script accordingly. This will make version validation more robust.


Expand Down
Loading