Conversation
Summary of ChangesHello @akao-amd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the upcoming ROCm v7.1.x software stack into the SGLang Docker build system. This update is critical for facilitating early evaluation and adoption of SGLang with the latest ROCm version. It primarily involves adding new base images for gfx942 and gfx950 GPUs and implementing conditional Python version switching to resolve build compatibility issues for components like TileLang and LLVM. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for ROCm 7.1.0 base images for both gfx942 and gfx950 architectures. A key part of this change is a workaround in the Dockerfile to temporarily switch from Python 3.12 to 3.10 during the TileLang/LLVM build process, as required, and then switch back. The changes look reasonable and address the goal of integrating with the new ROCm stack.
I have two suggestions for improvement:
- Correct a minor typo in an example build command to ensure it uses the correct image tag.
- Refactor the Python version switching logic to merge two
RUNcommands into one. This will improve the Docker image by reducing the number of layers and keeping related logic together.
3b2c757 to
bc194db
Compare
bc194db to
11030b3
Compare
|
Change Log:
|
49b9577 to
d7df2fb
Compare
9f66a5a to
004706b
Compare
282393e to
d56ebda
Compare
b5136e8 to
6258628
Compare
* Enable an preview image build * Hot patch: aiter for mla_asm and sglang for moe * With release-docker-amd-rocm720-preview.yml
6258628 to
1ea381f
Compare
|
Closing in favor of #17799 |
For both gfx942/gfx950 images, we add a new version of base image based on latest ROCm v7.1.x.
Motivation
As ROCm v7.1.x is around the corner now, integrating SGLang onto the new software stack is critical for internal/external early evaluation and adoption.
Modifications
Accuracy Tests
N/A
Benchmarking and Profiling
N/A
Checklist
N/A