fix sgl kernel marlin fp8 bias

[qeternity]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @qeternity, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a fix related to how bias is handled within the SGL kernel for Marlin FP8 quantization. The change refactors the bias application to occur post-kernel execution in Python, ensuring correct and robust integration of bias in the FP8 Marlin linear layers.

Highlights

• Bias Application Logic: The mechanism for applying bias in the apply_fp8_marlin_linear function has been updated. Bias is now explicitly added to the output after the marlin_fp8_linear CUDA kernel completes its execution.
• CUDA Kernel Interaction: The b_bias parameter has been removed from the direct call to the marlin_fp8_linear CUDA kernel, indicating that the kernel itself no longer handles bias internally, delegating this task to the Python wrapper.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with bias handling for the FP8 Marlin kernel. The change refactors the bias addition to occur after the gptq_marlin_gemm operation, rather than passing it as a parameter to the kernel. This aligns the implementation with other Marlin-based quantization methods in the codebase, such as GPTQ and AWQ, which handle bias in the same way. The modification appears to be a correct and necessary fix. The code is clean and the change is well-contained.

[qeternity]

#13571