Skip to content

[Minor] Temporarily skipping deepep large mtp test #14586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 1 commit into from
Dec 7, 2025
Merged

[Minor] Temporarily skipping deepep large mtp test #14586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/srt/ep/test_deepep_large.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def test_gsm8k(self):
self.assertGreater(metrics["accuracy"], 0.92)


@unittest.skip("Skipping this test until it's fixed.")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to provide a more descriptive reason for skipping a test. This helps other developers understand the context without having to dig through git history. Consider mentioning who is working on the fix, as noted in the PR description, and linking to a tracking issue if one exists.

Suggested change
@unittest.skip("Skipping this test until it's fixed.")
@unittest.skip("Skipping this test as it is currently broken. @rainj-me is working on a fix.")

class TestDeepseekMTP(CustomTestCase):
@classmethod
def setUpClass(cls):
Expand Down
Loading