update custom_logit_processor.py for. GLM-4.5 and GLM-4.6 support#14568
update custom_logit_processor.py for. GLM-4.5 and GLM-4.6 support#14568zRzRzRzRzRzRzR wants to merge 9 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @zRzRzRzRzRzRzR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system's capability to integrate with GLM-4.5 and GLM-4.6 models by adding a dedicated logit processor. This ensures that the 'thinking' phase of these specific models is correctly managed through their unique token identifiers, which is crucial for their proper operation and output generation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the Glm4MoeThinkingBudgetLogitProcessor to support thinking budget control for GLM-4.5 and GLM-4.6 models. The implementation correctly follows the existing design by subclassing ThinkingBudgetLogitProcessor and providing the necessary model-specific token IDs. The change is clean, well-documented, and appears correct. I have no suggestions for improvement.
|
/tag-and-rerun-ci |
|
Thanks for your PR. I just cherry-picked into my branch and added you as coauthor. Let's track this PR instead: #14585. Thank you for your understanding! |
No description provided.