Closed
Conversation
hnyls2002
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
Collaborator
|
cc @rainj-me |
rainj-me
reviewed
Dec 4, 2025
| dtype=q.dtype, | ||
| device=q.device, | ||
| ) | ||
| q = self.pad_draft_extend_query( |
Collaborator
There was a problem hiding this comment.
After removing the pad_draft_extend_query call, maybe we should already delete the relate code.
| # Reshape output directly without slicing | ||
|
|
||
| if forward_batch.forward_mode.is_draft_extend(include_v2=True): | ||
| raw_out = self.unpad_draft_extend_output( |
rainj-me
reviewed
Dec 4, 2025
| else: | ||
| draft_logits_output, _ = self.draft_runner.forward( | ||
| forward_batch, skip_attn_backend_init=True | ||
| forward_batch, skip_attn_backend_init=False |
Collaborator
There was a problem hiding this comment.
skip attn backend lead to the flashinfer backend cudagraph capture failure.
Collaborator
Author
|
This PR is closed due to #13115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To completely fix the issue, it requires
prepare_mlp_sync_batch) intoScheduler.prepare_mlp_sync_batch.skip_attn_backend_init.ForwardModeinto more reliable status representation.