-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[6/n] Fix num_token_non_padded computation in prefill
#14313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ch-wan
merged 17 commits into
sgl-project:main
from
yuchengz816-bot:prefill_num_token_non_padded
Dec 11, 2025
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
64d79f6
test git
yuchengz816-bot e12de44
extended the num_token_non_padded fix to prefill case
yuchengz816-bot 1f8a8ed
refactored the code - v2
yuchengz816-bot 955319d
refactored the code - v3
yuchengz816-bot ee47003
deleted redundant conversion
yuchengz816-bot a31bbbf
polished format
yuchengz816-bot 20d28ad
covered the decode w/o cg case
yuchengz816-bot ce72bef
added none check for global_num_tokens_gpu
yuchengz816-bot 8027421
fixed index out of range bug
yuchengz816-bot 2e12b35
Merge branch 'main' into prefill_num_token_non_padded
ch-wan c46ac51
Merge branch 'main' into prefill_num_token_non_padded
ch-wan 57db758
Merge branch 'main' into prefill_num_token_non_padded
yhyang201 3f06ed2
deleted the use of item()
yuchengz816-bot b75c62b
added a func to handle diff clamp cases
yuchengz816-bot 4931266
modularised code
yuchengz816-bot 2166fb5
used torch.clamp() instead
yuchengz816-bot 9e053a2
Merge branch 'main' into prefill_num_token_non_padded
ch-wan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid this
item()?