Skip to content

Fix gpt-oss yarn with truncate argument #14270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hnyls2002 merged 3 commits into from
Dec 18, 2025
Merged

Fix gpt-oss yarn with truncate argument #14270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52f50c0
fix
hnyls2002 Dec 2, 2025
9ec319c
fix
hnyls2002 Dec 2, 2025
69f6101
Merge branch 'main' into lsyin/fix-gpt-oss-truncate-rope
hnyls2002 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions python/sglang/srt/layers/rotary_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,13 +531,13 @@ def _yarn_find_correction_range(
dim: int,
base: float = 10000,
max_position_embeddings: int = 2048,
truncate: bool = True,
) -> Tuple[int, int]:
low = math.floor(
_yarn_find_correction_dim(low_rot, dim, base, max_position_embeddings)
)
high = math.ceil(
_yarn_find_correction_dim(high_rot, dim, base, max_position_embeddings)
)
low = _yarn_find_correction_dim(low_rot, dim, base, max_position_embeddings)
high = _yarn_find_correction_dim(high_rot, dim, base, max_position_embeddings)
if truncate:
low = math.floor(low)
high = math.ceil(high)
return max(low, 0), min(high, dim - 1) # Clamp values just in case


Expand Down Expand Up @@ -578,12 +578,14 @@ def __init__(
attn_factor: float = 1,
beta_fast: int = 32,
beta_slow: int = 1,
truncate: bool = True,
) -> None:
self.scaling_factor = scaling_factor
self.extrapolation_factor = extrapolation_factor
self.attn_factor = attn_factor
self.beta_fast = beta_fast
self.beta_slow = beta_slow
self.truncate = truncate
# Get n-d magnitude scaling corrected for interpolation
self.mscale = float(_yarn_get_mscale(self.scaling_factor) * attn_factor)
super().__init__(
Expand All @@ -603,6 +605,7 @@ def _compute_inv_freq(self, scaling_factor: float) -> torch.Tensor:
self.rotary_dim,
self.base,
self.max_position_embeddings,
self.truncate,
)
# Get n-d rotational scaling corrected for extrapolation
inv_freq_mask = (
Expand Down Expand Up @@ -2648,6 +2651,7 @@ def get_rope(
if k
in ("extrapolation_factor", "attn_factor", "beta_fast", "beta_slow")
}
extra_kwargs["truncate"] = rope_scaling.get("truncate", True)
rotary_emb = YaRNScalingRotaryEmbedding(
head_size,
rotary_dim,
Expand Down
Loading