fix: small changes to enable test_mrope.py

[raayandhar]

Motivation

Currently test_mrope.py is broken. There are two issues: one related to server args, and one related to using forward_native and not _forward_native

Modifications

Add dummy server args and change the test back to _forward_native. The original pr (#11859) used forward_native but in a follow-up pr this was changed to _forward_native: #11859

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.
• Work with maintainers to merge your PR. See the PR Merge Process

[raayandhar]

cc: @yuan-luo

[raayandhar]

I also noticed that some PRs made changes to this file. But it is clear that it was not tested since when testing on their commit, it still failed. Just as FYI.

[yuan-luo]

@raayandhar Please paste the UT passed result.

[raayandhar]

@raayandhar Please paste the UT passed result.

Thanks, here it is:

UT test results (click to expand)

(sglang) ynez% pytest test/srt/rotary_embedding/test_mrope.py -v
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.12.3, pytest-9.0.1, pluggy-1.6.0 -- /home/raayan/projects/sglang/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/raayan/projects/sglang/test
configfile: pytest.ini
plugins: anyio-4.11.0
collected 24 items                                                                                                                                                         

test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-1-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                        [  4%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-1-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                       [  8%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-1-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                     [ 12%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-2-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                        [ 16%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-2-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                       [ 20%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype0-2-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                     [ 25%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-1-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                        [ 29%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-1-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                       [ 33%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-1-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                     [ 37%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-2-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                        [ 41%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-2-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                       [ 45%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[11-dtype1-2-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                     [ 50%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-1-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                      [ 54%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-1-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                     [ 58%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-1-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                   [ 62%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-2-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                      [ 66%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-2-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                     [ 70%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype0-2-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                   [ 75%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-1-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                      [ 79%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-1-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                     [ 83%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-1-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                   [ 87%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-2-model_info0-Qwen/Qwen2-VL-7B-Instruct] PASSED                                                      [ 91%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-2-model_info1-Qwen/Qwen2-VL-72B-Instruct] PASSED                                                     [ 95%]
test/srt/rotary_embedding/test_mrope.py::test_mrope[8192-dtype1-2-model_info2-Qwen/Qwen2.5-VL-72B-Instruct] PASSED                                                   [100%]

============================================================================= warnings summary =============================================================================
.venv/lib/python3.12/site-packages/_pytest/config/__init__.py:1397
  /home/raayan/projects/sglang/.venv/lib/python3.12/site-packages/_pytest/config/__init__.py:1397: PytestConfigWarning: Unknown config option: asyncio_mode
  
    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================ 24 passed, 3 warnings in 72.46s (0:01:12) =================================================================
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute
(sglang) ynez% 

[raayandhar]

Also, I imagine that this test was disabled in CI ... once we are happy with the fix, how should we re-enable it?

[yuan-luo]

Also, I imagine that this test was disabled in CI ... once we are happy with the fix, how should we re-enable it?

Sure, we should re-enable the test in CI.

[raayandhar]

Also, I imagine that this test was disabled in CI ... once we are happy with the fix, how should we re-enable it?

Sure, we should re-enable the test in CI.

I found it here:

sglang/test/srt/run_suite.py

Line 74 in e12c78a

TestFile("rotary_embedding/test_mrope.py", 10),

So I guess it was never disabled? Not sure how this is possible