Skip to content

[CI] CI registry update#13927

Merged
hnyls2002 merged 2 commits intomainfrom
lsyin/udpate-ci-registry
Nov 25, 2025
Merged

[CI] CI registry update#13927
hnyls2002 merged 2 commits intomainfrom
lsyin/udpate-ci-registry

Conversation

@hnyls2002
Copy link
Collaborator

A step to migrate to #13808. From #13653

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the continuous integration (CI) test registration system. It introduces new capabilities to mark tests for nightly execution or to disable them with a specified reason, providing greater control over the CI pipeline. The underlying parsing mechanism for these registration markers has been refactored for improved robustness and clarity, and the changes are reflected in the updated testing documentation.

Highlights

  • Enhanced CI Registration: Introduced nightly and disabled parameters to CI registration functions (register_cpu_ci, register_cuda_ci, register_amd_ci), allowing tests to be designated for nightly runs or temporarily disabled with a reason.
  • Robust Argument Parsing: Refactored the internal argument parsing logic for CI registration markers, improving error handling and supporting both positional and keyword arguments for est_time, suite, nightly, and disabled.
  • Updated Documentation: Added a "CI Registry Quick Peek" section to test/README.md to document the new CI metadata declaration syntax.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hnyls2002
Copy link
Collaborator Author

/tag-and-rerun-ci

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the CI test registration mechanism by moving from a basic AST parsing implementation to a much more robust and feature-rich one. The new implementation correctly handles positional and keyword arguments, validates argument types, and supports new metadata fields like nightly and disabled. The addition of documentation in test/README.md is also a great touch. My feedback includes a couple of suggestions to further improve the new argument parsing logic in _parse_call_args for better maintainability and more informative error messages.

@hnyls2002 hnyls2002 merged commit d3d404d into main Nov 25, 2025
68 of 104 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/udpate-ci-registry branch November 25, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant