Skip to content

Fix nightly test job to fail when any test fails #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kangyan-Zhou merged 1 commit into from
Nov 25, 2025
Merged

Fix nightly test job to fail when any test fails #13871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/run_suite_nightly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import argparse
import os
import sys
from pathlib import Path

from sglang.test.ci.ci_utils import TestFile, run_unittest_files
Expand Down Expand Up @@ -75,11 +76,12 @@ def main():
print(f"Running {len(files)} tests from suite: {args.suite}")
print(f"Test files: {[f.name for f in files]}")

run_unittest_files(
exit_code = run_unittest_files(
files,
timeout_per_file=args.timeout_per_file,
continue_on_error=args.continue_on_error,
)
sys.exit(exit_code)
Comment on lines +79 to +84
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is functionally correct. For improved conciseness, you can directly pass the return value of run_unittest_files to sys.exit. This avoids the need for an intermediate exit_code variable and is a common Python idiom.

Suggested change
exit_code = run_unittest_files(
files,
timeout_per_file=args.timeout_per_file,
continue_on_error=args.continue_on_error,
)
sys.exit(exit_code)
sys.exit(
run_unittest_files(
files,
timeout_per_file=args.timeout_per_file,
continue_on_error=args.continue_on_error,
)
)



if __name__ == "__main__":
Expand Down
Loading