Skip to content

Tiny unpin uvloop for other backends #13858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hnyls2002 merged 1 commit into from
Nov 24, 2025
Merged

Tiny unpin uvloop for other backends #13858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyproject_cpu.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ dependencies = [
"tqdm",
"transformers==4.57.1",
"uvicorn",
"uvloop==0.21.0",
"uvloop",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Completely unpinning the uvloop dependency can introduce instability. If a future version of uvloop contains breaking changes, it could break builds or cause unexpected runtime behavior. It is safer to specify a compatible version range. Using ~=0.21.0 allows for patch releases (e.g., 0.21.1) but prevents potentially breaking minor or major version updates (e.g., 0.22.0), striking a good balance between receiving bug fixes and maintaining stability.

Suggested change
"uvloop",
"uvloop~=0.21.0",

"xgrammar==0.1.27",
"grpcio==1.75.1", # keep it align with compile_proto.py
"grpcio-tools==1.75.1", # keep it align with compile_proto.py
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject_other.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ runtime_common = [
"tqdm",
"transformers==4.57.1",
"uvicorn",
"uvloop==0.21.0",
"uvloop",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Completely unpinning the uvloop dependency can introduce instability. If a future version of uvloop contains breaking changes, it could break builds or cause unexpected runtime behavior. It is safer to specify a compatible version range. Using ~=0.21.0 allows for patch releases (e.g., 0.21.1) but prevents potentially breaking minor or major version updates (e.g., 0.22.0), striking a good balance between receiving bug fixes and maintaining stability.

Suggested change
"uvloop",
"uvloop~=0.21.0",

"xgrammar==0.1.27",
"grpcio==1.75.1", # keep it align with compile_proto.py
"grpcio-tools==1.75.1", # keep it align with compile_proto.py
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject_xpu.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ dependencies = [
"tqdm",
"transformers==4.57.1",
"uvicorn",
"uvloop==0.21.0",
"uvloop",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Completely unpinning the uvloop dependency can introduce instability. If a future version of uvloop contains breaking changes, it could break builds or cause unexpected runtime behavior. It is safer to specify a compatible version range. Using ~=0.21.0 allows for patch releases (e.g., 0.21.1) but prevents potentially breaking minor or major version updates (e.g., 0.22.0), striking a good balance between receiving bug fixes and maintaining stability.

Suggested change
"uvloop",
"uvloop~=0.21.0",

# "xgrammar==0.1.24", , xgrammar depends on CUDA PyTorch and Triton only
"grpcio==1.75.1", # keep it align with compile_proto.py
"grpcio-tools==1.75.1", # keep it align with compile_proto.py
Expand Down
Loading