Skip to content

add LoRA warning if loading a preexisting LoRA adapter with a different name #13822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 2 commits into from
Nov 24, 2025
Merged

add LoRA warning if loading a preexisting LoRA adapter with a different name #13822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccfdef5
add lora warning
glenliu21 Nov 24, 2025
7335484
gemini fix
glenliu21 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions python/sglang/srt/lora/lora_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,17 @@ def validate_new_adapter(self, lora_config: LoRAConfig, lora_ref: LoRARef):
"""

# Check if this LoRA adapter is already loaded
if any(
lora_ref.lora_name == existing_lora_ref.lora_name
for existing_lora_ref in self.lora_refs.values()
):
raise ValueError(
f"Failed to load LoRA adapter {lora_ref.lora_name} because it is already loaded"
)
for existing_lora_ref in self.lora_refs.values():
if lora_ref.lora_name == existing_lora_ref.lora_name:
raise ValueError(
f"Failed to load LoRA adapter {lora_ref.lora_name} because it is already loaded"
)

if lora_ref.lora_path == existing_lora_ref.lora_path:
logger.warning(
f"{lora_ref.lora_path} is already loaded with name: {existing_lora_ref.lora_name}, "
f"but another copy is being loaded with name: {lora_ref.lora_name}"
)

# Check if the LoRA adapter shape is compatible with the current LoRA memory pool configuration.
memory_pool = getattr(self, "memory_pool", None)
Expand Down
Loading