-
Notifications
You must be signed in to change notification settings - Fork 5k
Refactor cache init logic #13800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor cache init logic #13800
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
22003c8
type type hint
hnyls2002 a414610
tiny rename
hnyls2002 355f392
use from environ
hnyls2002 bd7a817
update
hnyls2002 815c9a0
support cache init params
hnyls2002 f3f31f9
simplify
hnyls2002 cda8953
simplify
hnyls2002 e49bda6
udpate
hnyls2002 90bdcdd
migrate lmcache
hnyls2002 9398603
man! what can I say: mamba out!
hnyls2002 442307e
Merge branch 'main' into lsyin/optimize-cache-init
hnyls2002 a50fe5f
migrate swa cache
hnyls2002 dedea51
migrate hicache
hnyls2002 c272443
optinal import hicache
hnyls2002 e3cffc1
simplify
hnyls2002 c161de3
adjust format
hnyls2002 d3dab6d
fix type
hnyls2002 a36fc4f
migrate hicache
hnyls2002 61f5999
tmp
hnyls2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import dataclasses | ||
| from typing import TYPE_CHECKING, Optional | ||
|
|
||
| import torch | ||
|
|
||
| if TYPE_CHECKING: | ||
| from sglang.srt.mem_cache.allocator import BaseTokenToKVPoolAllocator | ||
| from sglang.srt.mem_cache.memory_pool import ReqToTokenPool | ||
|
|
||
|
|
||
| @dataclasses.dataclass | ||
| class CacheInitParams: | ||
| disable: bool | ||
| req_to_token_pool: ReqToTokenPool | ||
| token_to_kv_pool_allocator: BaseTokenToKVPoolAllocator | ||
| page_size: int | ||
|
|
||
| is_eagle: bool = False | ||
| tp_cache_group: Optional[torch.distributed.ProcessGroup] = None | ||
| eviction_policy: str = "lru" | ||
| disable_finished_insert: bool = False | ||
|
|
||
| enable_metrics: bool = False | ||
| enable_kv_cache_events: bool = False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great refactoring to introduce
CacheInitParamsand centralize the cache initialization parameters. I notice thatRadixCache,ChunkCache, andSWAChunkCachehave been updated to accept theparamsobject directly. However, other cache implementations likeRadixCacheCpp,HiRadixCache,SWARadixCache,MambaRadixCache, andLMCRadixCacheare still initialized with individual arguments.To improve consistency and maintainability, it would be beneficial to extend this refactoring to these other cache classes as well, so they also accept a
CacheInitParamsobject in their constructors.