Skip to content

[diffusion] doc: minor update contributing.md with test section #13792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickqian merged 3 commits into from
Nov 24, 2025
Merged

[diffusion] doc: minor update contributing.md with test section #13792

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce33703
[diffusion] doc: minor update contributing with test section
mickqian Nov 23, 2025
93b133c
upd
mickqian Nov 23, 2025
8b2b667
Update python/sglang/multimodal_gen/docs/contributing.md
mickqian Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/sglang/multimodal_gen/docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,13 @@ For PRs that impact **latency**, **throughput**, or **memory usage**, you **shou
...
```
4. **Paste**: paste the table into the PR description

## 3. CI-Based Change Protection

Consider adding tests to the `pr-test` or `nightly-test` suites to safeguard your changes, especially for PRs that:

1. support a new model
2. support or fix important features
3. significantly improve performance

See [test](https://github.com/sgl-project/sglang/tree/main/python/sglang/multimodal_gen/test) for examples
Loading