Skip to content

[CI] minor hot fix of model validation list #13737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hnyls2002 merged 1 commit into from
Nov 21, 2025
Merged

[CI] minor hot fix of model validation list #13737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/ci/validate_and_download_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
"Qwen/QwQ-32B-AWQ",
"Qwen/Qwen3-30B-A3B",
"Skywork/Skywork-Reward-Llama-3.1-8B-v0.2",
"neuralmagic/DeepSeek-Coder-V2-Lite-Instruct-FP8",
"lmms-lab/llava-onevision-qwen2-7b-ov",
Comment on lines +70 to +71
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the maintainability of this long list, please add new models in alphabetical order. The two models you've added here are not sorted alphabetically.

Additionally, it would be good practice to group models from the same organization. The new lmms-lab model could be placed next to the existing one on line 46.

Ideally, the entire list for 1-gpu-runner should be sorted alphabetically to make it easier to manage in the future.

Suggested change
"neuralmagic/DeepSeek-Coder-V2-Lite-Instruct-FP8",
"lmms-lab/llava-onevision-qwen2-7b-ov",
"lmms-lab/llava-onevision-qwen2-7b-ov",
"neuralmagic/DeepSeek-Coder-V2-Lite-Instruct-FP8",

# diffusion
"Qwen/Qwen-Image",
"Qwen/Qwen-Image-Edit",
Expand Down
Loading