Gather static input buffers for cuda graph#13676
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To combat with data race between scheduler and model runner, the effective approach iis to fully decouple the two components by staging all dynamic model inputs in pre-allocated static buffers. This transforms the interaction between scheduler and model runner into SPSC pattern.
As the first step, this PR is to organize the static buffers needed for forward.
Note that this is not the complete list. Some tensors such as
req_to_tokenare static and captured in graph.Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist