Skip to content

[Router bugfix] Fix router_manager selecting the wrong router when enable-igw. #13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slin1237 merged 2 commits into from
Nov 25, 2025
Merged

[Router bugfix] Fix router_manager selecting the wrong router when enable-igw. #13572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf87f6
bugfix: fix router_manager select the wrong router when enable-igw an…
SYChen123 Nov 20, 2025
e059d3c
cleancode
SYChen123 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion sgl-router/src/routers/router_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ impl RouterManager {
let mut best_router = None;
let mut best_score = 0.0;

let num_regular_workers = self
.worker_registry
.get_all()
.iter()
.filter(|w| matches!(w.worker_type(), WorkerType::Regular))
.count();
let num_pd_workers = self.worker_registry.get_all().len() - num_regular_workers;

for router in candidate_routers {
let mut score = 1.0;

Expand All @@ -284,7 +292,9 @@ impl RouterManager {
// - Average worker cost vs max_cost
// - Current load and health status

if score > best_score {
let valid_router = (router.is_pd_mode() && num_pd_workers > 0)
|| (!router.is_pd_mode() && num_regular_workers > 0);
if score > best_score && valid_router {
best_score = score;
best_router = Some(router);
}
Expand Down
Loading