Skip to content

[CI] re-enable test_vision_openai_server_a ci #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 2 commits into from
Nov 18, 2025
+18 −10
Merged

[CI] re-enable test_vision_openai_server_a ci #13444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4640db0
upd
yhyang201 Nov 17, 2025
dab9e5b
upd
yhyang201 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/srt/run_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
TestFile("test_triton_sliding_window.py", 100),
TestFile("test_utils_update_weights.py", 48),
TestFile("test_vision_chunked_prefill.py", 170),
# TestFile("test_vision_openai_server_a.py", 900),
TestFile("test_vision_openai_server_a.py", 900),
TestFile("test_vlm_input_format.py", 300),
TestFile("test_modelopt_loader.py", 30),
TestFile("test_modelopt_export.py", 30),
Expand Down Expand Up @@ -365,7 +365,7 @@
TestFile("test_verl_engine_4_gpu.py"),
TestFile("test_verl_engine_server.py"),
TestFile("test_vertex_endpoint.py"),
TestFile("test_vision_openai_server_a.py"), # TODO: Fix timeout
# TestFile("test_vision_openai_server_a.py"), # TODO: Fix timeout
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since test_vision_openai_server_a.py is now included in the per-commit-1-gpu test suite, this line in the __not_in_ci__ list is no longer necessary. For better code clarity, it's best to remove this line entirely rather than commenting it out. Additionally, the TODO: Fix timeout comment seems to be obsolete given the context of this pull request, which re-enables the test.

TestFile("test_vision_openai_server_b.py"),
TestFile("test_vision_openai_server_common.py"),
TestFile("test_vlm_accuracy.py"),
Expand Down
24 changes: 16 additions & 8 deletions test/srt/test_vision_openai_server_a.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,16 @@

import unittest

import openai
from test_vision_openai_server_common import *
from test_vision_openai_server_common import ( # DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,; DEFAULT_URL_FOR_TEST,; IMAGE_MAN_IRONING_URL,; popen_launch_server,
AudioOpenAITestMixin,
CustomTestCase,
ImageOpenAITestMixin,
OmniOpenAITestMixin,
TestOpenAIMLLMServerBase,
VideoOpenAITestMixin,
)
Comment on lines 10 to +18
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The wildcard import on line 10 is redundant and not good practice as it pollutes the global namespace and makes it hard to track where names are coming from. The explicit import on lines 11-18 is a good step, but it's incomplete and coexists with the wildcard import. It's better to have a single, clean, explicit import statement. The commented-out names on line 11 are actually used in this file and should be imported explicitly. I suggest combining these into a single, comprehensive import statement and removing the wildcard import and the commented-out names.

from test_vision_openai_server_common import (
    DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
    DEFAULT_URL_FOR_TEST,
    IMAGE_MAN_IRONING_URL,
    AudioOpenAITestMixin,
    CustomTestCase,
    ImageOpenAITestMixin,
    OmniOpenAITestMixin,
    TestOpenAIMLLMServerBase,
    VideoOpenAITestMixin,
    popen_launch_server,
)



class TestLlavaServer(ImageOpenAITestMixin):
Expand Down Expand Up @@ -207,12 +216,11 @@ def test_single_image_chat_completion(self):


if __name__ == "__main__":
# Note: Cannot delete mixin classes imported via * since they're not in local scope
# del (
# TestOpenAIMLLMServerBase,
# ImageOpenAITestMixin,
# VideoOpenAITestMixin,
# AudioOpenAITestMixin,
# OmniOpenAITestMixin,
# )
del (
TestOpenAIMLLMServerBase,
ImageOpenAITestMixin,
VideoOpenAITestMixin,
AudioOpenAITestMixin,
OmniOpenAITestMixin,
)
unittest.main()
Loading