[1/N] CI refactor: introduce CI register.#13345
Conversation
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates a refactoring of the CI system by introducing a new mechanism for registering and categorizing unit tests. It provides a Python module that uses Abstract Syntax Tree (AST) parsing to identify test classes and extract their associated CI configuration, such as required hardware backend, estimated execution time, and CI stage, through dedicated decorators. This change lays the groundwork for a more structured and automated CI pipeline, enabling dynamic test selection and execution based on defined metadata. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility script for parsing CI test decorators from test files. The approach of using an AST visitor is solid. I've provided feedback on a few areas to improve robustness and correctness: fixing a typo, using dataclasses for data-holding classes to fix a bug and improve clarity, and refactoring the AST visiting and argument parsing logic to be more robust and readable.
0a18177 to
7255579
Compare
1. Add python/sglang/test/ci/__init__.py to fix ModuleNotFoundError when importing from sglang.test.ci module (missing since PR #13345) 2. Add stage-b-test-2-gpu workflow job to run the stage-b-test-small-2-gpu suite which is used by test_lora_tp.py
1. Add python/sglang/test/ci/__init__.py to fix ModuleNotFoundError when importing from sglang.test.ci module (missing since PR #13345) 2. Add stage-b-test-2-gpu workflow job to run the stage-b-test-small-2-gpu suite which is used by test_lora_tp.py
This PR:
langtests.test_srt_backend.pyinto the new CI folderper_commit