Clean up deprecated tile_tokens_dim for next flashinfer#13341
Clean up deprecated tile_tokens_dim for next flashinfer#13341hnyls2002 merged 1 commit intosgl-project:mainfrom
Conversation
Signed-off-by: Vincent Zhong <207368749+vincentzed@users.noreply.github.com>
Summary of ChangesHello @vincentzed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the codebase by removing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request performs a clean-up by removing the deprecated tile_tokens_dim argument from calls to FlashInfer's MoE kernels across four different files. The changes are consistent and correctly applied, preparing the codebase for future updates of the FlashInfer library. The modifications are straightforward and I have no concerns.
…project#13341)" This reverts commit 0d116b9.
… and sgl-project#13341) (sgl-project#13348)" This reverts commit 78a4b44.
…project#13341)" This reverts commit 0d116b9.
Motivation
When flashinfer 0.5.3 out, it will no longer be accepted
flashinfer-ai/flashinfer#2086
It already does nothing, and is passed as
None(and unused flashinfer side)Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist