Support internvl on Blackwell (which doesn't support fa3): add SingletonCache support to Vision{Sdpa|Triton|Ascend}Attention#13151
Conversation
Summary of ChangesHello @netanel-haber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of cumulative sequence lengths (cu_seqlens) by introducing a new helper function, resolve_seqlens. This change centralizes duplicated logic from several vision attention implementations, improving code reuse and clarity. It also adds SingletonCache support to VisionTritonAttention and VisionAscendAttention, making them consistent with other attention modules. The type hints are also updated to the modern | syntax. The changes are solid, and I have one suggestion to further improve the readability of the new helper function.
…on,VisionAscendAttention, thus fixing internvl support on blackwell, which doesn't support fa3
3de4dde to
3d652f7
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-and-sdpa-singleton-attention
SingletonCache support to Vision{Sdpa|Triton|Ascend}Attention
…-and-sdpa-singleton-attention
…-and-sdpa-singleton-attention
|
@yhyang201 - this is another small orthogonal pr for my nano-vl pr that touches encoder code. Perhaps you can take a look? |
…-and-sdpa-singleton-attention
…-and-sdpa-singleton-attention
|
I think this is ready to be merged. |
…-and-sdpa-singleton-attention
Unblocks blackwell support for: #12277