Skip to content

Conversation

@zRzRzRzRzRzRzR
Copy link
Contributor

Simple bug fix.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zRzRzRzRzRzRzR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the GLM-4-MOE model where a key attribute, self.first_k_dense_replace, was not being properly initialized. By explicitly assigning its value from the model's configuration during object creation, this change ensures the model's stability and correct operation, preventing runtime errors related to an undefined attribute.

Highlights

  • Bug Fix: Initialized the self.first_k_dense_replace attribute within the __init__ method of the GLM-4-MOE model, resolving an 'undefined' error.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug where self.first_k_dense_replace was used in Glm4MoeModel without being initialized. The change adds the necessary initialization in the __init__ method, resolving the AttributeError. The fix is straightforward and correct.

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as draft October 31, 2025 14:54
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as ready for review November 2, 2025 04:46
@zRzRzRzRzRzRzR
Copy link
Contributor Author

It seems the current CI failure is caused by the deepeesk_v3 test file not working, not GLM.

@hnyls2002 hnyls2002 merged commit a889c85 into sgl-project:main Nov 5, 2025
30 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants