[CPU] add support for mamba causal conv1d for qwen3-next#12309
Merged
FlamingoPg merged 10 commits intosgl-project:mainfrom Dec 4, 2025
Merged
[CPU] add support for mamba causal conv1d for qwen3-next#12309FlamingoPg merged 10 commits intosgl-project:mainfrom
FlamingoPg merged 10 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
4 tasks
09d256d to
fe93cef
Compare
4283bf6 to
7db502b
Compare
Collaborator
Author
|
fix new lint error. |
7db502b to
0abfa78
Compare
2 tasks
FlamingoPg
approved these changes
Dec 4, 2025
tom-jerr
pushed a commit
to tom-jerr/sglang
that referenced
this pull request
Dec 4, 2025
yingluosanqian
pushed a commit
to yingluosanqian/sglang
that referenced
this pull request
Dec 4, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
yuchengz816-bot
pushed a commit
to yuchengz816-bot/sglang
that referenced
this pull request
Dec 8, 2025
Kevin-XiongC
pushed a commit
to novitalabs/sglang
that referenced
this pull request
Dec 9, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 12, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 12, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
add support for mamba causal conv1d for qwen3-next
Modifications
add kernel files at
sgl-kernel/csrc/cpu/mamba/conv.cpp, which implemented bothcausal_conv1d_fwdfor prefill andcausal_conv1d_updatefor decode.xto be contiguous on the second-to-last dimension to achieve optimal performanceconv_statesto be contiguous the second-to-last dimension to make sure vectorized load from memoryAccuracy Tests
Benchmarking and Profiling
compare the optimized C++ version against reference implementation with native torch (which will end up with oneDNN)
performance collected on 6th gen Xeon with 40 cores, with script.
NOTE: the main reason for low performance with torch native implementation is that PyTorch doesn't have
channels lastconcept for 1d convolution. On PyTorch, 1d convolution will be mapped to 2d and therefore it will always be channels first. This will trigger:Checklist