fix(metrics): double times add_latency for DECODE_BOOTSTRAP

[jimmy-evo]

add_latency for DECODE_BOOTSTRAP multi times

#8710
@acelyc111

[gemini-code-assist]

Summary of Changes

Hello @jinmingyi1998, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the metrics collection system that caused the DECODE_BOOTSTRAP latency to be overcounted. By eliminating a duplicate add_latency call, the change ensures that performance metrics for the decoding bootstrap phase are accurately captured, providing a more reliable representation of system performance.

Highlights

• Metrics Fix: Resolved an issue where the DECODE_BOOTSTRAP latency was being recorded multiple times, leading to inaccurate performance metrics.
• Code Cleanup: Removed a redundant add_latency call within the pop_preallocated function in decode.py to ensure correct metric reporting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request removes a line that added latency for the DECODE_BOOTSTRAP request stage in the pop_preallocated function of the decode.py file. The change aims to address issue #8710, where the latency was being added multiple times. I have identified one issue of high severity.

[acelyc111]

thanks for the fix!

[acelyc111]

@jinmingyi1998 The duplicate lines seem introduced by #10912