-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CI] Fix b200 flashinfer installation #11915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shangming Cai <[email protected]>
Summary of ChangesHello @ShangmingCai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and fixes issues within the B200 CI environment by refining the dependency installation script. The changes ensure that the correct versions of the main project package and its associated dependencies are installed based on whether the CI is running on a Blackwell system or a standard environment, thereby improving the reliability and consistency of the continuous integration process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the CI environment for Blackwell (b200) GPUs by separating the package installation logic from the standard environment. The previous implementation incorrectly applied installation steps meant for the normal CI, which uses uv, to the Blackwell environment, which uses pip. The changes resolve this by moving the uv-specific steps into an else block and adding a dedicated pip installation command for the Blackwell case. The fix appears sound. I have added one suggestion to refactor the installation script for the non-Blackwell case to improve clarity and reduce redundancy.
Signed-off-by: Shangming Cai <[email protected]>
Motivation
A supplement PR of #11902.
This can fix https://github.com/sgl-project/sglang/actions/runs/18681539949/job/53280297485:
TODO: restore the original logic when flashinfer-ai/flashinfer#1962 and flashinfer-ai/flashinfer#1960 are addressed.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist