-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[router] openai router: support grok model #11511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @key4ng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for the Grok model into the existing router, leveraging an XAI OpenAI compatible API. The core objective is to enable seamless interaction with Grok, including conversational history and advanced tool-use capabilities via Multi-Chain Prompting. To achieve this, the PR refines the request and response structures, making certain parameters optional and implementing specific data transformations to bridge the compatibility gaps between the router's internal specification and XAI's API requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Grok model in the OpenAI router by making several request fields optional to handle API differences. The changes are well-implemented across the codebase, including updates to data structures, default values, and tests. I've identified a few areas for improvement: some leftover debugging code should be removed, there's a potential typo in a field name, and a complex block of code could be refactored to enhance readability and maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Motivation
Support xai openai compatible api in openai router. now it supports history management and mcp execution for grok model.
Modifications
itemas input, so it doesn't supportidandstatusfieldoutput_textas type of assistant content, so mark it toinput_textAccuracy Tests
Using xai backend
base call
append history by providing previous_response_id
MCP call
streaming also tested
Benchmarking and Profiling
Checklist