-
Notifications
You must be signed in to change notification settings - Fork 5k
Separate allocation logic from scheduler #11313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9f238a4
match_prefix
cctry c0fc6a0
fix
cctry baa34d7
prepare_for_extend: adjust order
cctry ffc57c0
prepare_for_extend: unify indices writing
cctry 75e3cf7
clean
cctry 3fe0dd6
clean
cctry ebb29fc
set prefix_indices default
cctry 5fa6bbf
fix chunk cache
cctry 9d7b32f
prepare_for_extend
cctry a30f56b
move functions out
cctry 4d4a272
better
cctry e3e1d28
wip
cctry 217fa5b
wip
cctry 2b54ecc
Merge remote-tracking branch 'origin/main' into shiyang/mem_v2/alloc
cctry ba41c12
clean
cctry d498464
clean
cctry 4e0bb42
clean
cctry 6c29a88
Merge remote-tracking branch 'origin/main' into shiyang/mem_v2/alloc
cctry 2e8d1a4
fix benchmark
cctry 987a3dd
fix hybrid
cctry bd22a18
update error msg
cctry 563ba3a
swa
cctry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why hard-code to 1 instead
page_size=model_runner.server_args.page_size?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out. wIll fix this