Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sgl-kernel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ format: check-deps ## Format all source files
FILES_TO_UPDATE = python/sgl_kernel/version.py \
pyproject.toml \
pyproject_rocm.toml \
pyproject_cpu.toml \
../docker/Dockerfile \
../.github/workflows/pr-test-pd-router.yml
pyproject_cpu.toml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing ../docker/Dockerfile and ../.github/workflows/pr-test-pd-router.yml from FILES_TO_UPDATE will prevent the make update command from updating version numbers in these files. This can lead to inconsistencies and outdated builds. For instance, docker/Dockerfile on line 88 still references version 0.3.10. This will cause Docker images to be built with an outdated kernel. Was this change intentional? If not, I recommend re-adding those files to FILES_TO_UPDATE to ensure consistent versioning across the project.

                 pyproject_cpu.toml \
                 ../docker/Dockerfile \
                 ../.github/workflows/pr-test-pd-router.yml


update: ## Update version numbers across project files. Usage: make update <new_version>
@if [ -z "$(filter-out $@,$(MAKECMDGOALS))" ]; then \
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.3.10"
version = "0.3.11"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.10"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject_cpu.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.3.10"
version = "0.3.11"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.10"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject_rocm.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "sgl-kernel"
version = "0.3.10"
version = "0.3.11"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.10"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/python/sgl_kernel/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.3.10"
__version__ = "0.3.11"
Loading