Conversation
Contributor
Author
|
This is a naive CI verification to discover potential illegal memory issues when disable FlashInfer is enabled. ref #981 |
Merged
Contributor
|
move to #1039 |
Hide-on-bushsh
pushed a commit
to Hide-on-bushsh/sgl-project
that referenced
this pull request
Jul 20, 2026
efschu
pushed a commit
to efschu/htsglang
that referenced
this pull request
Sep 1, 2026
…neither idle nor a stall
1068cap (2026-09-01): 4 group flip pairs, the SAME 3-request cohort seam-
re-prefilled from zero in every TP window (442840 tok total), zero decode
batches ever built. Two arm faces of one booking blind spot -- the policy
has no notion of 're-prefilling toward decode':
(A) windows 1+4: 'pending prefill > 0 ... nothing decoding' armed ~13 s in,
while the cohort sat queued (bundle_is_mid_flight correctly answers
False for queued-retracted per W37-E -- but not-decoding is not
not-owed-this-layout's-service).
(B) windows 2+3: 'decode bundle STALLED, set has not shrunk for 51.8s'
fired at a member whose prefix was actively growing -- the progress
clock knew only bs-shrink (:4155).
One mechanism, two sites, no new ledger:
- observe_idle: sinking seam_cohort_pending_tokens credits the bundle
progress clock (state marker last_seam_cohort_pending, phase-entry reset).
- the purity/pending tp_to_pp arm holds while seam_cohort_dwell_active()
(same sgl-project#1032 FIX 1 bound: lapses after SEAM_COHORT_DWELL_ROUNDS, so it can
never hold forever); named holding line is the metal instrument.
Desk-proven by execution: clock clause truth table (sink=progress,
flat/rise=not), dwell predicate arms both ways. Metal falsifier: driver
load must reach Decode batch > 0 with flips still reconciling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.
Motivation
Please explain the motivation behind this PR and the goal you aim to achieve with it.
Modification
Briefly describe the changes made in this PR.
Checklist
pre-commit run --all-filesor other linting tools are used to fix potential lint issues.