refine ci workflow #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mingfeima, can you please kindly help to review the PR to refine kernel ci pipeline? |
mingfeima
reviewed
Sep 24, 2025
tests/run_suite.py
Outdated
| estimated_time: float = 60 | ||
|
|
||
|
|
||
| # Add Intel Xeon tests |
There was a problem hiding this comment.
this should be xpu tests, right?
| } | ||
|
|
||
|
|
||
| def auto_partition(files, rank, size): |
There was a problem hiding this comment.
can you elaborate more what does this function do?
There was a problem hiding this comment.
this file is fully ported from sglang main, aiming to achieve load balance when tests workload is heavy. we may not use this function for now. Shall I remove this function?
|
How much time does each CI run take for now? |
6-8 mins for the whole process. 5 mins for docker build and 1-2 mins for kernel test. |
chunyuan-w
reviewed
Nov 5, 2025
airMeng
approved these changes
Nov 5, 2025
chunyuan-w
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to optimize the CI pipeline by aligning the testing workflow with the sglang main repository. The key change is to adopt run_suite.py as the central script for managing test scope, replacing ad-hoc test selection logic. This improves consistency, maintainability, and scalability of CI across platforms.
Motivation
By aligning with the sglang main repo’s practice of using run_suite.py, we can:
✅ Centralize test suite definitions.
✅ Enable dynamic and reusable test scope management.
✅ Simplify future additions (e.g., new platforms(BMG, CRI), test categories).
python run_suite.py --suite per-commit
Key Changes: