Skip to content

Conversation

@jia-rundong
Copy link
Contributor

@jia-rundong jia-rundong commented Sep 11, 2025

Description

  1. This PR introduces CI support for the -a deepep build argument.
  2. Merge two test workflows into one action to eliminate redundant builds.
  3. Set HCCL_BUFFSIZE to the minimum value constrained in the code to verify its correctness.

Fixes #73

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jia-rundong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build process within the container by introducing the capability to pass specific build arguments. This change provides greater flexibility and control over how the deep_ep package is built, allowing for more customized or environment-specific builds without modifying the core build script directly.

Highlights

  • Script Argument Handling: The prepare_deepep_in_container.sh script now supports passing custom build arguments to the underlying build.sh script via a new command-line option.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to pass build arguments to the prepare_deepep_in_container.sh script, which are then passed on to build.sh. The implementation is sound. My feedback includes a couple of suggestions to enhance the script's robustness and maintainability. I recommend adding set -euo pipefail for stricter error handling and refactoring the conditional build command execution for better clarity and extensibility.

@jia-rundong jia-rundong changed the title Add build args Add UT to build args -a deepep Sep 11, 2025
@jia-rundong jia-rundong changed the title Add UT to build args -a deepep Add CI to test args -a deepep Sep 11, 2025
@Yael-X Yael-X merged commit 32d5437 into sgl-project:main Sep 16, 2025
7 checks passed
@jia-rundong jia-rundong deleted the ut_deepep branch September 17, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wait to be solved]CI efficiency issue

2 participants