feat:add performance compare#311
Conversation
Summary of ChangesHello @Yael-X, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a dedicated performance comparison script to evaluate the efficiency of DeepEP communication against HCCL communication in a Mixture-of-Experts (MoE) context. The script meticulously benchmarks the dispatch and combine operations for both implementations, providing quantitative data on their relative performance and correctness. This addition is crucial for understanding the performance implications of different communication backends in distributed MoE systems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a performance comparison script between DeepEP and HCCL for MoE communication. The new script is well-structured for benchmarking and includes correctness checks. I've found a critical issue with a constructor call that will likely cause a runtime error, along with a few medium-severity suggestions to improve code quality and maintainability, such as removing dead code, avoiding magic numbers, and improving resource management.
* upstream/main: fix little batchsize and int8 quant on ci (sgl-project#302) optimize sinks attention (sgl-project#260) add swiglu_oai_triton (sgl-project#270) update tag to 2026.01.12 (sgl-project#312) feat:add performance compare (sgl-project#311) support add_gemma_rms_norm (sgl-project#310) optimize gdn gating and fused_qkvzba_split_reshape_cat (sgl-project#306) fix layout numTokensPerExpertTensor partial Initialization bug (sgl-project#303) Supplement A2 doc, software and hardware compatibility info (sgl-project#294) Added an environment variable to control whether to enable the Combine Ant Migration feature. (sgl-project#304)
* feat:add performance compare * feat:lintcode
The HCCL implementation is added for performance comparison, where the dispatch and combine principles of the HCCL implementation are the same as those in vllm-ascend. This script can directly compare the performance of DeepEP communication and HCCL communication used in MoE communication. One of the test data sets is as follows: