Repository navigation
diffusion-ci: restore main-compatible Sana H100 GT - #6
Merged
Merged
Conversation
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sana_wm_ti2v_1gpuconsistency frames to the blobs used before88b17d4.Why this is needed
88b17d4(Update SANA TI2V H100 consistency ground truth) captured output from the unmerged warmup-calibrated auto-residency experiment in sgl-project/sglang#35335 / the stacked sgl-project/sglang#36703 work, rather than output from SGLangmain.That experiment introduced post-warmup residency changes in
7f66f1cand enabled them in diffusion CI indfb2cfeby removingSGLANG_DIFFUSION_DISABLE_AUTO_RESIDENCY=1. On the Sana H100 case, the runtime changed placement after warmup:The two-stage Sana path was not numerically invariant under those transitions. The old-GT comparison in run 33124193263, partition 3 reported:
Those are exactly the metrics observed in the opposite direction when the normal mainline Sana output is compared with the
88b17d4images in sgl-project/sglang#36680. The experimental PR subsequently documented the problem and opted Sana out withsupports_auto_residency = Falsein0834013; it later moved its CI-data pin back from88b17d4to its parent in137286c.Because sgl-project/sglang#35335 is still unmerged, SGLang
mainnever adopted the path that produced the replacement images. Current mainline Sana runs remain bit-exact with the pre-88b17d4ground truth. The experimental images nevertheless remained in the shared ci-data history and were unintentionally pulled into sgl-project/sglang#36680 when that PR advanced the repository-wide revision to include the unrelated Qwen-Image GT from #5.This PR removes that cross-PR contamination instead of weakening Sana thresholds or blessing output from an unmerged, already-disabled numerical path.
Validation
f8c4481d1fa2fa1b9efdfe6831d9c60dbf386b4a, the parent of88b17d4:e47c0559f4f9545a92be9f1417208549db3ecd0468706eb5ec3f03b439e4f23df7f89f91d4a1ddceb2f4938b90be6731b4ba5e9400267137274d3e48Follow-up
After this merges, sgl-project/sglang#36680 should update
SGL_TEST_FILES_CI_DATA_REVISIONto this PR's merge commit and rerun the multimodal-generation CI.References:
88b17d4fca324f9994d6f9f58495ed3882700734