QOpenGLWidget GLSL and WSpinny fixes. by rryan · Pull Request #1 · sgielen/mixxx

rryan · 2018-12-29T03:08:34Z

Be-ing · 2018-12-29T06:14:01Z

GLSL is working again on Linux with Intel graphics, but spinnies are distorted (regardless of scale factor):

rryan · 2018-12-29T17:29:49Z

Huh, that's weird. Especially because WSpinny is painted with QPainter, not OpenGL functions.

daschuer · 2018-12-30T08:16:20Z

Did you pick the right target branch?
This PR also contains master changes.
I think merging master should be done directly in the original PR.

rryan · 2018-12-30T17:03:54Z

Did you pick the right target branch?
This PR also contains master changes.
I think merging master should be done directly in the original PR.

Master has changes that the base branch doesn't have that my branch builds on. I didn't want to wait for @sgielen to merge (and it had some conflicts that I had more context on how to resolve).

rryan · 2018-12-30T17:06:26Z

Did this ever work?
If not, can we meet this directly to master?

It did -- but with QOpenGLWidget it doesn't because isValid always returns false until the widget isVisible, so I don't think it makes sense in master until @sgielen's PR merges.

rryan · 2018-12-30T17:07:41Z

Alternatively I'm happy to take over this work and open a separate PR against mixxxdj/mixxx.

daschuer · 2018-12-30T22:37:10Z

Did this ever work?
If not, can we meet this directly to master?

It did -- but with QOpenGLWidget it doesn't because isValid always returns false until the widget isVisible, so I don't think it makes sense in master until @sgielen's PR merges.

Do we have an alternative fallback solution?

solution win xp installation

…s Master

added udev rule for AlphaTheta devices

To adjust the size there are the half/double buttons and this behavior is closer to the mapping of other controllers like the VCI-400

… once.

TrackDAO: Add missing const qualifiers

Pin Xcode version to 9.4.1 on Travis CI

…-delete widget/wcolorpicker: Set button pointer to nullptr after delete

…metadata

Fix build with EXTRA_METADATA enabled / Update dirty flag

resolve conflicts, Fix OpenGL status

…s this itself.

This has no effect on macOS because the widget's QOpenGLContext is not created until the widget is shown or resized, but its removal may be causing segfaults on Linux.

With QOpenGLWidget, no work should be done in constructors since our QOpenGLContext is not valid until the widget is shown. QAbstractOpenGLFunctions::initializeOpenGLFunctions is cheap (only does work if it has never been called), so we can call it on every draw() without a performance penalty.

This reverts commit 53f6e16.

…the QMainWindow. This removes the need to use QGuiApplication::focusWindow() or to walk the list of top level windows to get the QMainWindow. It also hides some implementation details of WaveformWidgetFactory from the rest of Mixxx.

…TS_PATH% existing.

…setConfig.

rryan mentioned this pull request Dec 29, 2018

Replace use of QGLWidget with QOpenGLWidget mixxxdj/mixxx#1863

Closed

rryan force-pushed the qopenglwidget branch 3 times, most recently from 7d0990b to a59416f Compare January 3, 2019 04:01

rryan force-pushed the qopenglwidget branch from a59416f to ac7a8ed Compare January 13, 2019 03:50

rryan force-pushed the qopenglwidget branch from ac7a8ed to a1a8857 Compare February 9, 2019 17:35

sgielen pushed a commit that referenced this pull request Mar 18, 2019

Merge pull request #1 from legendary-acp/legendary-acp

6b4ee96

solution win xp installation

daschuer and others added 16 commits March 29, 2020 03:29

Added line-length.py to call clang-format for lines > 100 only

f236949

fix line length to the desired 100 and reduce indentation

a5db490

fix typo

e72f7b7

use underscore instead of dash

fc65ff7

Avoid intermediate variable

61b52e6

removed unused and unnecessary methods

e96c90e

Made the dryWetKnob increment/decrement value tweakable

b5284e2

added udev rule for AlphaTheta devices

eb435da

Made it tweakable which VU meter to show Master or Channel. Default i…

a204f72

…s Master

Merge pull request mixxxdj#2609 from Swiftb0y/alpha-theta-udev-rule

b89937b

added udev rule for AlphaTheta devices

Changed beatLoop encoder to move loop instead of adjust its size

22f72d3

To adjust the size there are the half/double buttons and this behavior is closer to the mapping of other controllers like the VCI-400

restore WPushButton debug tooltip

e5981f0

consolidate WPushButton events

582c76f

Extract threshold parameters and fix to format multible long lines at…

864f7f8

… once.

Added mapping for the CROSSFADER CURVE knob

347eb89

Use capital style with underscores for the Python constants

fbcc980

uklotzde and others added 30 commits April 11, 2020 19:29

Fix build with EXTRA_METADATA enabled

06c795d

Pin Xcode version to 9.4.1 on Travis CI

40f8345

TrackDAO: Add missing const qualifiers

a7ddd35

Update dirty flag when merging imported metadata

d547721

Reword documentation

27107df

Merge pull request mixxxdj#2654 from uklotzde/trackdao_const

df620e9

TrackDAO: Add missing const qualifiers

Merge pull request mixxxdj#2655 from uklotzde/travis_xcode

9996fe5

Pin Xcode version to 9.4.1 on Travis CI

Merge branch 'master' into extra_metadata

d5d48bb

widget/wcolorpicker: Set button pointer to nullptr after delete

49215fa

Merge pull request mixxxdj#2657 from Holzhaus/fix-wcolorpicker-button…

d9eb97f

…-delete widget/wcolorpicker: Set button pointer to nullptr after delete

Break long lines

e1ac686

Merge branch 'master' of git@github.com:mixxxdj/mixxx.git into extra_…

5945ae3

…metadata

Restore accidentally deleted lines

d11cc41

Merge pull request mixxxdj#2652 from uklotzde/extra_metadata

53498cb

Fix build with EXTRA_METADATA enabled / Update dirty flag

Merge pull request #15 from daschuer/qopenglwidget

319d5fd

resolve conflicts, Fix OpenGL status

Merge branch 'master' into qopenglwidget

35a11cc

Update CMakeLists.txt to include added/removed files.

d9e434c

Remove unused header inclusion.

c6ad608

Use a range-based for loop.

2876411

Rename getAtNextSwap to getPlayPositionAtNextSwap to be more explicit.

f4500ac

Fix mistakes made when merging.

99f6e5b

No need to guard QWidget::update() with isVisible(), since update doe…

a1cc05d

…s this itself.

Clarify and update some comments. Remove commented debugging printlines.

1e5cafb

Restore QOpenGLWidget::makeCurrent() calls in constructors.

53f6e16

This has no effect on macOS because the widget's QOpenGLContext is not created until the widget is shown or resized, but its removal may be causing segfaults on Linux.

Revert "Restore QOpenGLWidget::makeCurrent() calls in constructors."

8644fc6

This reverts commit 53f6e16.

Fix the Windows build with Qt 5.14.2.

ada2b2a

Attempt to fix the AppVeyor build when mkdir fails due to %ENVIRONMEN…

6860728

…TS_PATH% existing.

Use setFrameRate to set the configured FPS in WaveformWidgetFactory::…

44b2030

…setConfig.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QOpenGLWidget GLSL and WSpinny fixes.#1

QOpenGLWidget GLSL and WSpinny fixes.#1
rryan wants to merge 5647 commits into
sgielen:qopenglwidgetfrom
rryan:qopenglwidget

rryan commented Dec 29, 2018 •

edited

Loading

Uh oh!

Be-ing commented Dec 29, 2018

Uh oh!

rryan commented Dec 29, 2018

Uh oh!

daschuer commented Dec 30, 2018

Uh oh!

rryan commented Dec 30, 2018 •

edited

Loading

Uh oh!

rryan commented Dec 30, 2018

Uh oh!

rryan commented Dec 30, 2018

Uh oh!

daschuer commented Dec 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Conversation

rryan commented Dec 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Be-ing commented Dec 29, 2018

Uh oh!

rryan commented Dec 29, 2018

Uh oh!

daschuer commented Dec 30, 2018

Uh oh!

rryan commented Dec 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rryan commented Dec 30, 2018

Uh oh!

rryan commented Dec 30, 2018

Uh oh!

daschuer commented Dec 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

rryan commented Dec 29, 2018 •

edited

Loading

rryan commented Dec 30, 2018 •

edited

Loading