Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native_image): clean up construction of inputs #70

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix(native_image): clean up construction of inputs #70

merged 2 commits into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. fix(native_image): clean up construction of inputs 

    `depset` structures should be kept as flat as possible. C++ toolchain
files are also already `depset`s and thus shouldn't be passed into
`tools`.

Signed-off-by: Sam Gammon <[email protected]>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5e2899d View commit details
    Browse the repository at this point in the history

  2. fix: modern rule check 

    - fix: explicitly check against modern rule status before resolving
  toolchain, unconditionally take it if running modern
- fix: direct deps for `native_image_tool` attr
- fix: preserve legacy rule behavior

applies on top of sgammon#70

Signed-off-by: Sam Gammon <[email protected]>
    @sgammon
    sgammon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    07d3eed View commit details
    Browse the repository at this point in the history