Skip to content

Conversation

@dovahcrow
Copy link
Member

No description provided.

@dovahcrow
Copy link
Member Author

First, the commit "Delete EDA_plot#2.py" need to be squashed.

Copy link
Member Author

@dovahcrow dovahcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the files should be more informative, maybe you can name them with respect to their functionality.
Additionally, the tests/style/type checks should be passed.

@dovahcrow dovahcrow force-pushed the dataprep branch 2 times, most recently from b917805 to 55685ef Compare May 31, 2019 02:09
shub970 added a commit that referenced this pull request Jun 3, 2019
code refactoring #6

Signed-off-by: shub970 <[email protected]>
Copy link
Member Author

@dovahcrow dovahcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these minor fixes are done I think it can be committed.

Copy link
Member Author

@dovahcrow dovahcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left more comments

@dovahcrow dovahcrow force-pushed the dataprep branch 11 times, most recently from 20b9d71 to 1d07e13 Compare June 12, 2019 20:42
@dovahcrow dovahcrow changed the title WIP: Implement plot(df[, x, y]) and add CI Implement plot(df[, x, y]) and add CI Jun 12, 2019
@dovahcrow dovahcrow merged commit 3020453 into master Jun 12, 2019
@dovahcrow dovahcrow deleted the dataprep branch July 6, 2019 23:18
dovahcrow added a commit that referenced this pull request May 29, 2020
Implement `plot(df[, x, y])` and add CI
fatbuddy added a commit to fatbuddy/dataprep that referenced this pull request Feb 10, 2024
fatbuddy added a commit to fatbuddy/dataprep that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants