fix: offer .txt in the Open dialog (#535) - #537
Merged
Conversation
Markpad already treats `.txt` as one of its own documents everywhere that matters: `hasMarkdownLinkExtension` accepts it, so a `.txt` opens, renders, follows wikilinks, reloads on external change and saves back under its own extension; the drop handler routes it to open; the Rust side lists it in MARKDOWN_LINK_EXTENSIONS too. The Open dialog was the one place that spelled the set out by hand, and it spelled four of the five. So the files opened fine but were invisible in the picker unless the user switched the filter to "All Files" — which reads as "Markpad cannot open .txt", and is what #535 reports. Fixed at the list rather than at the symptom: the filter now takes the exported MARKDOWN_LINK_EXTENSIONS, so the sixth place that needs this set cannot be the next one to miss an entry. The installer still does not claim `.txt` (#179/#302) — that association belongs to the system text editor, and taking it is a different act from being able to open the file. Both halves of that policy now sit in fileAssociations.test.ts so neither moves unseen. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535.
Markpad already treats
.txtas one of its own documents everywhere that matters —hasMarkdownLinkExtensionaccepts it, so a.txtopens, renders, follows wikilinks, reloads on external change and saves back under its own extension; the drop handler routes it to open; the Rust side lists it inMARKDOWN_LINK_EXTENSIONStoo.The Open dialog was the one place that spelled the set out by hand, and it spelled four of the five. The files opened fine but were invisible in the picker unless the user switched the filter to "All Files", which reads as "Markpad cannot open .txt".
Fixed at the list rather than at the symptom: the filter now takes the exported
MARKDOWN_LINK_EXTENSIONS, so the sixth place that needs this set cannot be the next one to miss an entry.The installer still does not claim
.txt(#179 / #302) — that association belongs to the system text editor, and taking it is a different act from being able to open the file. Both halves of that policy now sit inscripts/fileAssociations.test.tsso neither side moves without the reader seeing the other.Validation:
npm run check— 0 errorsnpm test— 866 passing🤖 Generated with Claude Code