Skip to content

fix(settings): persist each setting on its own key and sync across windows #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PathGao merged 2 commits into from
Aug 2, 2026
Merged

fix(settings): persist each setting on its own key and sync across windows #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ef3a8
fix(settings): persist each setting on its own key and sync across wi…
PathGao Aug 2, 2026
bf23e75
settings: show range and default beside every numeric setting
PathGao Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/previewWidth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ test('the dedicated full-width preference takes priority over its legacy key', (

test('settings load, persist, and reset the preview width through one normalizer', () => {
assert.match(settingsSource, /previewMaxWidth = \$state\(DEFAULT_PREVIEW_MAX_WIDTH\)/);
assert.match(settingsSource, /localStorage\.getItem\('preview\.maxWidth'\)/);
// Persistence moved from one all-fields effect to one entry per localStorage
// key (so that a change in one window stops rewriting every other key from a
// stale snapshot). The preview width still round-trips under the same key and
// through the same normalizer; only the plumbing that reads and writes it is
// now shared. See scripts/settingsPersistence.test.ts.
assert.match(settingsSource, /key: 'preview\.maxWidth'/);
assert.match(settingsSource, /read: \(s\) => String\(s\.previewMaxWidth\)/);
assert.match(settingsSource, /normalizePreviewMaxWidth\(savedPreviewMaxWidth\)/);
assert.match(settingsSource, /localStorage\.setItem\('preview\.maxWidth', String\(this\.previewMaxWidth\)\)/);
assert.match(settingsSource, /resetPreviewMaxWidth\(\)[\s\S]*this\.previewMaxWidth = DEFAULT_PREVIEW_MAX_WIDTH/);
});

Expand Down
Loading
Loading