Keep Settings modal drag accessible - #312
Merged
PathGao merged 1 commit intoAug 2, 2026
Merged
Conversation
Collaborator
Author
|
@alecdotdev Follow-up to #310: the upgraded checker exposed one Settings drag-header accessibility warning. This keeps the existing pointer drag behavior and restores a clean check with a focused regression test. Please review after #310 and its predecessors. |
PathGao
force-pushed
the
fix/settings-modal-drag-accessibility
branch
from
August 2, 2026 03:57
eddd2af to
44a3ec3
Compare
alecdotdev
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311
Moves the pointer listener from the non-interactive header to the existing dialog element, while starting a drag only when the event originated from the header’s non-interactive surface. The close button remains excluded. This preserves mouse dragging without giving a header that contains a button an invalid interactive role.
Adds a regression test for the event ownership and scope.
This is stacked after #310; merge the predecessor chain first.
Validated with
npm run check(0 errors, 0 warnings),npm test(136 passing),npm run build, andcargo test(21 passing).