remove ELECTRIC_CURRENT_AMPERE device class declaration from Ah unit … #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registers Since "Ah" is a unit of charge, not current, it's not appropriate to use the "current" device class.
|
Thanks for opening this PR. However, instead of going to unit of measurement of type none I would rather add Ah/mAh as valid units of measurement to home assistant. approved for the core repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…registers
Since "Ah" is a unit of charge, not current, it's not appropriate to use the "current" device class.
This is to address the issue #86 that I just opened--I'm not quite sure if I got the syntax right.