Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: consistence arrow functions #62

Merged
merged 2 commits into from
Jul 28, 2020
Merged

docs: consistence arrow functions #62

merged 2 commits into from
Jul 28, 2020

Conversation

geromegrignon
Copy link
Contributor

intègre les arrow functions dans toutes les slides/exercices
supprime les var au profit de let/const

related to #38

@geromegrignon geromegrignon requested a review from jefBinomed July 8, 2020 12:57
jefBinomed
jefBinomed requested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@jefBinomed jefBinomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas mal de remarque sur la reprise des arrow functions avec uniquement 1 seul return dans leur corps. Il faut toutes les reprendre de façon à avoir direct le code de retour sans le return.

common/default-for-steps/workbox/templates/landing.html Outdated Show resolved Hide resolved
docs/markdown/02-serviceworkers/03-recap-promise.md Outdated Show resolved Hide resolved
docs/markdown/02-serviceworkers/03-recap-promise.md Outdated Show resolved Hide resolved
docs/markdown/02-serviceworkers/12-fetch-api-intro.md Outdated Show resolved Hide resolved
docs/markdown/03-cache/01-app-shell-intro.md Outdated Show resolved Hide resolved
docs/markdown/06-engaging/02-push.md Show resolved Hide resolved
steps/install-1-solution/service-worker.js Outdated Show resolved Hide resolved
steps/install-1-solution/service-worker.js Outdated Show resolved Hide resolved
steps/install-1-solution/service-worker.js Outdated Show resolved Hide resolved
steps/install-1-solution/templates/landing.html Outdated Show resolved Hide resolved
@geromegrignon geromegrignon merged commit 5cfb560 into master Jul 28, 2020
@geromegrignon geromegrignon deleted the arrow-function branch July 28, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefBinomed jefBinomed jefBinomed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geromegrignon @jefBinomed