Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't leave errors on the stack in MdCtxRef::digest_verify_final #2283

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

alex
Copy link
Collaborator

@alex alex commented Aug 25, 2024

No description provided.

@alex
Copy link
Collaborator Author

alex commented Aug 25, 2024

@sfackler let me know if you think this should just ignore teh errors, I'm not sure if Ok(false) ever actually occurs.

@botovq
Copy link
Contributor

botovq commented Aug 25, 2024

Ok(false) can happen: 1 signature is valid, 0 signature is invalid (typically no error on the stack), < 0 a library error occurred (typically error on the stack).

@sfackler
Copy link
Owner

This seems right to me. Must have been another example of a function where the return value docs used to be more specific.

@alex alex merged commit 36dcae8 into sfackler:master Aug 25, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants